[PATCH] D123451: [NFC] Rename `FixedLenDecoderEmitter` as `DecoderEmitter`

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 9 07:46:26 PDT 2022


0x59616e planned changes to this revision.
0x59616e added a comment.

Thanks ! I didn't expect you come so quick ;)

I've noticed the clang-format problem. The weird thing is, It didn't happen "before" I rename this file.

So I want to take some time looking into it.



================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:130
+  //       variable length opcode, we might have to migrate webassembly to use
+  //       that.
   if (Target.getName() == "WebAssembly") {
----------------
RKSimon wrote:
> Raise a bug to track this?
I change this TODO just for reflecting the status of this decoder emitter to avoid confusing someone.

Resolving this means we need to deploy our varlen encoding infra onto webassembly  backend. I don't know whether this is a good idea since this is a non-trivial work I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123451/new/

https://reviews.llvm.org/D123451



More information about the llvm-commits mailing list