[PATCH] D123451: [NFC] Rename `FixedLenDecoderEmitter` as `DecoderEmitter`
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 9 04:48:42 PDT 2022
RKSimon added subscribers: myhsu, RKSimon.
RKSimon added reviewers: RKSimon, myhsu.
RKSimon added a comment.
No objections from me @myhsu ? Just a few minors to address.
There's some clang formatting that needs to be done since you've changed the length :-) of the class name
================
Comment at: llvm/utils/TableGen/DecoderEmitter.cpp:2699
+ DecoderEmitter(RK, PredicateNamespace, GPrefix, GPostfix,
ROK, RFail, L).run(OS);
}
----------------
clang format
================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:103
const std::string &ROK,
const std::string &RFail, const std::string &L);
----------------
clang format
================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:130
+ // variable length opcode, we might have to migrate webassembly to use
+ // that.
if (Target.getName() == "WebAssembly") {
----------------
Raise a bug to track this?
================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:147
" MCDisassembler::DecodeStatus S = "
"MCDisassembler::Success;\n(void)S;");
return;
----------------
clang format
================
Comment at: llvm/utils/TableGen/DisassemblerEmitter.cpp:153
" == MCDisassembler::Fail)", "MCDisassembler::Success",
"MCDisassembler::Fail", "");
}
----------------
clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123451/new/
https://reviews.llvm.org/D123451
More information about the llvm-commits
mailing list