[PATCH] D123276: [lld-macho] Use fewer indirections in UnwindInfo implementation

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 19:32:19 PDT 2022


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:98
 
-template <class Ptr> struct CompactUnwindEntry {
+template <class Ptr> struct CompactUnwindLayout {
   Ptr functionAddress;
----------------
oontvoo wrote:
> It seems a little iffy to me that we need this additional struct ... (Would be great to have only one of these two...)
> 
> 
mm I further "simplify" it in {D123277}, lmk what you think :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123276/new/

https://reviews.llvm.org/D123276



More information about the llvm-commits mailing list