[PATCH] D123411: lld/AMDGPU: Fix asserts if no object files are involved in link

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 11:15:47 PDT 2022


arsenm added inline comments.


================
Comment at: lld/test/ELF/amdgpu-elf-flags.s:5
 # RUN: ld.lld -shared %t-0.o %t-1.o -o %t.so
-# RUN: llvm-readobj --file-headers %t.so | FileCheck %s
+# RUN: llvm-readobj --file-headers %t.so | FileCheck -check-prefix=FIRSTLINK %s
 
----------------
MaskRay wrote:
> Nit: for FileCheck options `--` is more common
I don't think so. I'd guess across llvm about 10% use -- for check-prefix


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123411/new/

https://reviews.llvm.org/D123411



More information about the llvm-commits mailing list