[PATCH] D123411: lld/AMDGPU: Fix asserts if no object files are involved in link

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM with some nits



================
Comment at: lld/test/ELF/amdgpu-elf-flags.s:5
 # RUN: ld.lld -shared %t-0.o %t-1.o -o %t.so
-# RUN: llvm-readobj --file-headers %t.so | FileCheck %s
+# RUN: llvm-readobj --file-headers %t.so | FileCheck -check-prefix=FIRSTLINK %s
 
----------------
Nit: for FileCheck options `--` is more common


================
Comment at: lld/test/ELF/amdgpu-elf-flags.s:11
+
+# FIRSTLINK: Flags [
+# FIRSTLINK-NEXT:   EF_AMDGPU_MACH_AMDGCN_GFX803 (0x2A)
----------------
Align the values like:
```
# FIRSTLINK:      Flags [
# FIRSTLINK-NEXT:   EF_AMDGPU_MACH_AMDGCN_GFX803 (0x2A)
# FIRSTLINK-NEXT: ]
```


================
Comment at: lld/test/ELF/amdgpu-elf-flags.s:15
+
+# SECONDLINK: Flags [ (0x0)
+# SECONDLINK-NEXT: ]
----------------
ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123411/new/

https://reviews.llvm.org/D123411