[PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

Fri Apr 8 05:20:05 PDT 2022

rovka added inline comments.

================
Comment at: flang/test/Driver/pass-pipeline.f90:33
+! CHECK: FIRToLLVMLowering
+! CHECK-NOT: LLVMIRLoweringPass
----------------
It seems tco and flang-new lower from the LLVM dialect to LLVM IR slightly differently. tco uses a [[ https://github.com/llvm/llvm-project/blob/f1cfa461f28ed5bf77ca2e8f26cbf66fa09481a0/flang/tools/tco/tco.cpp#L115 | pass ]], but flang-new [[ https://github.com/llvm/llvm-project/blob/09c2b7c35af8c4bad39f03e9f60df8bd07323028/flang/lib/Frontend/FrontendActions.cpp#L440 | doesn't ]]. I put this check here in case we ever switch flang-new to use the pass, like tco does.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171