[PATCH] D115352: [AArch64] Add mayRaiseFPException to appropriate instructions

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

In D115352#3419239 <https://reviews.llvm.org/D115352#3419239>, @john.brawn wrote:

> In D115352#3399965 <https://reviews.llvm.org/D115352#3399965>, @dmgreen wrote:
>
>> The original version of this patch was altering the non-strict codegen because the flags were lost in the machine combiner. Have you done any other testing to make sure that doesn't happen anywhere else? To make sure this doesn't pessimise the performance for the default non-strict case.
>
> I've build all of the MultiSource and SingleSource tests in llvm-test-suite with and without this patch (and those it depends on) at -O3 and there are no changes to the generated code.

Thanks for checking. There might be other patterns that more rarely come up, but if they don't come up there and in the llvm tests then that's at least a good sign.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115352/new/

https://reviews.llvm.org/D115352