[PATCH] D123338: [AMDGPU] Fix handling of gfx10 LDS misaligned access bug

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-local-128.mir:4
 # RUN: llc -amdgpu-global-isel-new-legality -march=amdgcn -mcpu=gfx900 -run-pass=instruction-select -verify-machineinstrs -global-isel-abort=0 -o - %s | FileCheck -check-prefix=GFX9 %s
-# RUN: llc -amdgpu-global-isel-new-legality -march=amdgcn -mcpu=gfx1010 -run-pass=instruction-select -verify-machineinstrs -global-isel-abort=0 -o - %s | FileCheck -check-prefix=GFX10 %s
+# RUN: llc -amdgpu-global-isel-new-legality -march=amdgcn -mcpu=gfx1010 -mattr=+cumode -run-pass=instruction-select -verify-machineinstrs -global-isel-abort=0 -o - %s | FileCheck -check-prefix=GFX10 %s
 
----------------
arsenm wrote:
> Should this get a runline with and without cumode?
It does not make sense, this must be legalized and test only runs selector.
But since it is not legal I would have to add -disable-gisel-legality-check and the test would become a no-op.
The relevant test is legalizer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123338/new/

https://reviews.llvm.org/D123338