[PATCH] D123301: [lld-macho][nfc] Factor out & micro-optimize findSymbolAtOffset

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1020
-        assert(referentIsec->wasCoalesced);
-        ++it;
-        continue;
----------------
int3 wrote:
> thakis wrote:
> > Previously we advanced it instead of doing `it = isec->relocs.erase(it)` if nothing was found. The rhs doesn't do that. Is that intentional?
> oops, good catch
I think erasing it might actually make more sense, but I'll revisit this in a future diff. this one is supposed to be a NFC


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123301/new/

https://reviews.llvm.org/D123301