[PATCH] D123301: [lld-macho][nfc] Factor out & micro-optimize findSymbolAtOffset

Thu Apr 7 06:04:51 PDT 2022

int3 added a comment.

Yeah I don't see any benchmark improvement... I guess it's not worth the additional code complexity

================
Comment at: lld/MachO/InputFiles.cpp:1020
-        assert(referentIsec->wasCoalesced);
-        ++it;
-        continue;
----------------
thakis wrote:
> Previously we advanced it instead of doing `it = isec->relocs.erase(it)` if nothing was found. The rhs doesn't do that. Is that intentional?
oops, good catch

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123301/new/

https://reviews.llvm.org/D123301