[PATCH] D122644: [RISCV] Add CMOV isel pattern for (select (setgt X, Imm), Y, Z)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 20:01:51 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/select-cc.ll:124
 ; RV32IBT-NEXT:    lw a1, 0(a1)
-; RV32IBT-NEXT:    slti a3, a2, 1
-; RV32IBT-NEXT:    cmov a0, a3, a0, a2
-; RV32IBT-NEXT:    sltz a2, a2
-; RV32IBT-NEXT:    cmov a0, a2, a1, a0
+; RV32IBT-NEXT:    slt a3, a2, a4
+; RV32IBT-NEXT:    cmov a0, a3, a0, a4
----------------
This doesn't look like it's doing what it was supposed to do. The immediate is in a register.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122644/new/

https://reviews.llvm.org/D122644



More information about the llvm-commits mailing list