[PATCH] D123169: AtomicExpand: Change return type for shouldExpandAtomicStoreInIR

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comments updated per previous comment.



================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:496
 
-void AtomicExpand::expandAtomicStore(StoreInst *SI) {
+bool AtomicExpand::expandAtomicStore(StoreInst *SI) {
   // This function is only called on atomic stores that are too large to be
----------------
The new boolean doesn't make sense on it's own.  Can you drop this from the current patch and add when the use is clear?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123169/new/

https://reviews.llvm.org/D123169