[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.

> The X86 tests should be enough on their own, right?

Most the common uses existed in the tests. 
If it cause very rarely/corner case fail, (I think almost no customers use it), let we fix it when we meet it.



================
Comment at: clang/lib/Basic/Targets/X86.cpp:1494
+  case 'p': // Keep 'p' constraint (address).
+    return std::string("p");
   case 't': // top of floating point stack.
----------------
Did you check the difference with the previous constraint "im" at llvm end.
Looks the C_Address is mostly same with C_Memory, but no relation with C_Immediate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122220/new/

https://reviews.llvm.org/D122220