[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 420424.
jonpa added a comment.

> Thanks for your job, I am not familiar with the SystemZ part, PLS make sure all tests passed.
> (+ Better to sync the clang format)
> If no others object it, I'll accepted 1 day later.

All tests are passing, and I fixed the one format issue that this patch introduced.

It would be great to get review on the common code + X86 changes at this stage. I think I could either commit the SystemZ part as well even if no review is given as it is follows quite trivially, or I could wait with that part and commit it at a later point. The X86 tests should be enough on their own, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122220/new/

https://reviews.llvm.org/D122220

Files:
  clang/lib/Basic/Targets/SystemZ.h
  clang/lib/Basic/Targets/X86.cpp
  clang/test/CodeGen/SystemZ/systemz-inline-asm-03.c
  clang/test/CodeGen/asm.c
  llvm/docs/LangRef.rst
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/include/llvm/IR/InlineAsm.h
  llvm/lib/CodeGen/CodeGenPrepare.cpp
  llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/test/CodeGen/SystemZ/inline-asm-addr.ll
  llvm/test/CodeGen/X86/inline-asm-p-constraint.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122220.420424.patch
Type: text/x-patch
Size: 14640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/e7539781/attachment.bin>