[PATCH] D122924: [lld] Add version info to generic driver output

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D122924#3431303 <https://reviews.llvm.org/D122924#3431303>, @kastiglione wrote:

> @MaskRay sorry for butting in, but what am I missing here? The hardline and opaque rejection don't reconcile with such a minor change. To me, there is no complexity whatsoever to this change. You mention consistency, but don't say with what (which doesn't allow people to make their own judgement). I also don't see how feature orthogonality relates. Rejections happen, but I think it's rejections ought to be clear to readers, and in this instance I found it confusing.

consistency: this is a fatal error. for other fatal errors we don't report the version.
i implied this in "In addition, error messages in lld don't append the version information." in a previous comment.

orthogonality: this is implied as well. `lld -flavor gnu --version` reports the version.

complexity: both `#include "lld/Common/Version.h"` and the function call is extra complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122924/new/

https://reviews.llvm.org/D122924