[PATCH] D122924: [lld] Add version info to generic driver output

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 17:46:35 PDT 2022


kastiglione added a comment.

@MaskRay sorry for butting in, but what am I missing here? The hardline and opaque rejection don't reconcile with such a minor change. To me, there is no complexity whatsoever to this change. You mention consistency, but don't say with what (which doesn't allow people to make their own judgement). I also don't see how feature orthogonality relates. Rejections happen, but I think it's rejections ought to be clear to readers, and in this instance I found it confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122924/new/

https://reviews.llvm.org/D122924



More information about the llvm-commits mailing list