[PATCH] D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:940
   /// size of the widest element type.
-  bool shouldMaximizeVectorBandwidth() const;
+  bool shouldMaximizeVectorBandwidth(TargetTransformInfo::RegisterKind K) const;
 
----------------
fhahn wrote:
> Document `K`?
Yep, let me add it.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:55
+    TargetTransformInfo::RegisterKind K) const {
+  if (K == TargetTransformInfo::RGK_ScalableVector)
+    return false;
----------------
fhahn wrote:
> simpler to just have `return K == TargetTransformInfo::RGK_FixedWidthVector;`?
> 
> Possibly with an assert that `K` is not `RGK_Scalar`.
Yep, let me update it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118979/new/

https://reviews.llvm.org/D118979