[PATCH] D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:940
   /// size of the widest element type.
-  bool shouldMaximizeVectorBandwidth() const;
+  bool shouldMaximizeVectorBandwidth(TargetTransformInfo::RegisterKind K) const;
 
----------------
Document `K`?


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:55
+    TargetTransformInfo::RegisterKind K) const {
+  if (K == TargetTransformInfo::RGK_ScalableVector)
+    return false;
----------------
simpler to just have `return K == TargetTransformInfo::RGK_FixedWidthVector;`?

Possibly with an assert that `K` is not `RGK_Scalar`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118979/new/

https://reviews.llvm.org/D118979