[PATCH] D123111: [AArch64] Make PMMIR_EL1 read-only.

Victor Campos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 02:38:13 PDT 2022


vhscampos added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SystemOperands.td:980
 def : RWSysReg<"PMOVSSET_EL0",       0b11, 0b011, 0b1001, 0b1110, 0b011>;
-def : RWSysReg<"PMMIR_EL1",          0b11, 0b000, 0b1001, 0b1110, 0b110>;
+def : ROSysReg<"PMMIR_EL1",          0b11, 0b000, 0b1001, 0b1110, 0b110>;
 def : RWSysReg<"MAIR_EL1",           0b11, 0b000, 0b1010, 0b0010, 0b000>;
----------------
There's a section further up in the file just for read-only registers. I recommend you move PMMIR_EL1 there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123111/new/

https://reviews.llvm.org/D123111



More information about the llvm-commits mailing list