[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D122251#3426344 <https://reviews.llvm.org/D122251#3426344>, @abrachet wrote:

> When using result_db output from lit we are seeing
>
>   Traceback (most recent call last):
>     File "/b/s/w/ir/x/w/staging/llvm_build/./bin/llvm-lit", line 50, in <module>
>       main(builtin_parameters)
>     File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/main.py", line 121, in main
>       report.write_results(tests_for_report, elapsed)
>     File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/reports.py", line 208, in write_results
>       gen_resultdb_test_entry(
>     File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/reports.py", line 163, in gen_resultdb_test_entry
>       'start_time': datetime.datetime.fromtimestamp(start_time).isoformat() + 'Z',
>   TypeError: an integer is required (got type NoneType)
>
> https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/reports.py#L163

I see you've reverted the patch. Thanks. It seems some output formats depend on `start_time` which is not synthesized for the shards, and strangely the lit tests for these formats did not trigger. I'll fix it and reland.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251