[PATCH] D122251: [lit] Use sharding for GoogleTest format

Mon Apr 4 10:30:02 PDT 2022

ychen added a comment.

In D122251#3426198 <https://reviews.llvm.org/D122251#3426198>, @thakis wrote:

> In D122251#3426061 <https://reviews.llvm.org/D122251#3426061>, @thakis wrote:
>
>> I don't see it discussed above: An advantage of the previous scheme is that it guarantees that there are no order dependencies between tests and that each tests passes in isolation.
>>
>> The speedup is nice, but it's also somewhat small relative to total `check-llvm` / `check-clang` time. Is that worth sacrificing guaranteed independent tests for?
>
> FWIW, I don't see a speedup on Win on my bot.
> Before: http://45.33.8.238/win/55580/summary.html
> After: http://45.33.8.238/win/55605/summary.html
>
> If anything, check-clang got 30s slower.

Probably there is some one-time cost involved?

http://45.33.8.238/win/55614/summary.html did not regress which is expected since these runs do not include unit tests.

> On linux, check-clang is 16 seconds faster (out of ~5 min total bot cycle time, so a 5.3% speedup) but none of the other test suites changed:
> Before: http://45.33.8.238/linux/72772/summary.html
> After: http://45.33.8.238/linux/72807/summary.html
>
> Do you see bigger wins on other bots?

Yeah, like
before (~270) https://lab.llvm.org/buildbot/#/builders/216/builds/2323/steps/7/logs/stdio
after (~240) https://lab.llvm.org/buildbot/#/builders/216/builds/2356/steps/7/logs/stdio

The time fluctuates to various degrees for bots. bot 216 is relatively stable and the speedup is what I would expect for a windows machine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251