[PATCH] D71178: [x86] Don't assume sign-extension of arguments smaller than 32-bits.

Sat Apr 2 04:50:01 PDT 2022

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.

In D71178#3424445 <https://reviews.llvm.org/D71178#3424445>, @emilio wrote:

> In D71178#3424386 <https://reviews.llvm.org/D71178#3424386>, @lebedev.ri wrote:
>
>> This seems backwards.
>> Who added those `signext`/`zeroext` attrs to the function arguments?
>> Presumably they just shouldn't be added if that is not what ABI states.
>
> Yes, see D72742 <https://reviews.llvm.org/D72742> for the right approach.

Yep, that seems more like it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71178/new/

https://reviews.llvm.org/D71178