[PATCH] D122939: [NVPTX][tests] Do not run the test CodeGen/Generic/2010-11-04-BigByval.ll

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 19:37:27 PDT 2022


MaskRay added a comment.

The test/CodeGen/Generic/ tests without `target triple` or `llc -mtriple=` tests the default target tripe. Can NVPTX be used as a default target triple?

There is some value in having such generic tests: we avoid duplicating them into every `test/CodeGen/${arch}/` directory. Such tests are a bit tricky for a contributor to update, though. By testing every possible default target means the output we can test is very limited.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122939/new/

https://reviews.llvm.org/D122939



More information about the llvm-commits mailing list