[PATCH] D122939: [NVPTX][tests] Do not run the test CodeGen/Generic/2010-11-04-BigByval.ll

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 13:54:10 PDT 2022


tra added a comment.

Does it mean that the test will be disabled for everyone with NVPTX back-end compiled in? That would not be the right thing to do, IMO.

While I agree that this particular test does not add much to NVPTX testing, I think we still may want it to run.

I'm also quite puzzled about `unacceptable run time when using XFAIL` and what NVPTX has to do with it. Are you saying that the test has unacceptable run time when NVPTX is the default architecture targeted by LLC?

Perhaps a better approach would be to run llc with explicit triple(s). It would have the benefit of making the test agnostic of the host or build options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122939/new/

https://reviews.llvm.org/D122939



More information about the llvm-commits mailing list