[PATCH] D122594: [ArgPromotion] Update min-legal-vector-width when do promotion

Thu Mar 31 22:12:41 PDT 2022

craig.topper added a comment.

In D122594#3421073 <https://reviews.llvm.org/D122594#3421073>, @pengfei wrote:

>> Is this IR illegal because @bar has a min-legal-vector-width of 256 but has 512 bit argument? The inliner can't create broken code from it.
>
> For one thing, if the IR is illegal, shouldn't we fix the place where it turns illegal, i.e., ArgumentPromotion in this example?
> For another, we are inlining `baz` to `foo` rather than `bar`. Do you mean we should scan all other callees of `foo` before the inlining? It doesn't make sense to me.

I think I wrote "inliner can't create" when I mean to write "inliner can create". I'm fine with fixing the ArgumentPromotion pass if the answer to the question of this IR illegal/unsupported is yes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122594/new/

https://reviews.llvm.org/D122594