[PATCH] D122594: [ArgPromotion] Update min-legal-vector-width when do promotion
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 31 20:30:45 PDT 2022
pengfei added a comment.
> Is this IR illegal because @bar has a min-legal-vector-width of 256 but has 512 bit argument? The inliner can't create broken code from it.
For one thing, if the IR is illegal, shouldn't we fix the place where it turns illegal, i.e., ArgumentPromotion in this example?
For another, we are inlining `baz` to `foo` rather than `bar`. Do you mean we should scan all other callees of `foo` before the inlining? It doesn't make sense to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122594/new/
https://reviews.llvm.org/D122594
More information about the llvm-commits
mailing list