[PATCH] D122106: [BOLT] Fix dynamic relocation offset for constant islands

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 15:39:37 PDT 2022


yota9 updated this revision to Diff 419578.
yota9 marked an inline comment as done.
yota9 added a comment.

@rafauler After some thinking I've desided to replace std::set with std::map. The relocations are identified by the offset field,
so it is good-enough solution that gives us fast search abilities and any inplace manipulations of the relocations struct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122106/new/

https://reviews.llvm.org/D122106

Files:
  bolt/include/bolt/Core/BinaryContext.h
  bolt/include/bolt/Core/BinarySection.h
  bolt/include/bolt/Core/Relocation.h
  bolt/lib/Core/BinaryContext.cpp
  bolt/lib/Core/BinaryEmitter.cpp
  bolt/lib/Core/BinaryFunction.cpp
  bolt/lib/Core/BinarySection.cpp
  bolt/lib/Core/Relocation.cpp
  bolt/lib/Rewrite/RewriteInstance.cpp
  bolt/test/AArch64/constant-island-dyn-rel.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122106.419578.patch
Type: text/x-patch
Size: 16367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220331/66c7936b/attachment.bin>


More information about the llvm-commits mailing list