[PATCH] D122106: [BOLT] Fix dynamic relocation offset for constant islands

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 15:19:23 PDT 2022


rafauler added a comment.

We can change BinarySection's RelocationSetType to be a sorted std::vector instead, as per https://llvm.org/docs/ProgrammersManual.html#a-sorted-vector

We would need to insert the relocations in any order, and then sort this vector and remove duplicates. Although I'm not convinced that we need to keep relocations in a sorted order or to remove duplicates. @maksfb  What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122106/new/

https://reviews.llvm.org/D122106



More information about the llvm-commits mailing list