[PATCH] D122566: [AArch64] Set MaxBytesForLoopAlignment for more targets

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 00:25:48 PDT 2022


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:82
   case CortexA35:
+    MaxBytesForLoopAlignment = 8;
     break;
----------------
NickGuy wrote:
> dmgreen wrote:
> > This needn't be set if there is no PrefLoopLogAlignment set too.
> > 
> > Either that, or it can be treated like a CortexA53/A55 below by adding it to the same case block.
> I missed that when adding the others, now added.
I would fold this into the CortexA53 block. The cpus in those blocks are similar, and I dont believe there is any reason to treat them differently for function alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122566/new/

https://reviews.llvm.org/D122566



More information about the llvm-commits mailing list