[PATCH] D122566: [AArch64] Set MaxBytesForLoopAlignment for more targets

Tue Mar 29 09:24:01 PDT 2022

NickGuy added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:82
   case CortexA35:
+    MaxBytesForLoopAlignment = 8;
     break;
----------------
dmgreen wrote:
> This needn't be set if there is no PrefLoopLogAlignment set too.
> 
> Either that, or it can be treated like a CortexA53/A55 below by adding it to the same case block.
I missed that when adding the others, now added.

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-p2align-max-bytes-neoverse.ll:9
+; RUN: llc -mtriple=aarch64-none-linux-gnu -mcpu=cortex-a75  < %s -o -| FileCheck %s --check-prefixes=CHECK,CHECK-8
+; RUN: llc -mtriple=aarch64-none-linux-gnu -mcpu=cortex-a510 < %s -o -| FileCheck %s --check-prefixes=CHECK,CHECK-8

----------------
dmgreen wrote:
> Should this be checking for 4, 8? Can we add some of the other cpus like A53 and A55 too?
Fixed, and added more of the effected cpus.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122566/new/

https://reviews.llvm.org/D122566