[PATCH] D122594: [ArgPromotion] Update min-legal-vector-width when do promotion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 09:43:43 PDT 2022


craig.topper added a comment.

In D122594#3417023 <https://reviews.llvm.org/D122594#3417023>, @craig.topper wrote:

> Have you debugged why areFunctionArgsABICompatible isn't preventing this properly?

Oh, I see the ArgumentPromotion wasn't wrong because the @foo and @bar both have min-legal-vector-width=0. Then @baz gets inlined into @baz and increases the min-legal-vector-width of @foo.

Is that really an inliner problem? Or are we assuming that if there is a vector argument, then min-legal-vector-width should always be >= the size of the vector argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122594/new/

https://reviews.llvm.org/D122594



More information about the llvm-commits mailing list