[PATCH] D122583: MIRParser: Fix asserting with invalid flags on machine operands

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: thegameg, arphaman, MatzeB, t.p.northover, craig.topper, dsanders.
Herald added subscribers: StephenFan, kerbowa, hiraditya, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Constructing an operand with kills on defs and deads on uses asserts
in the constructor, so diagnose these.


https://reviews.llvm.org/D122583

Files:
  llvm/lib/CodeGen/MIRParser/MIParser.cpp
  llvm/test/CodeGen/MIR/AMDGPU/dead-flag-on-use-operand-parse-error.mir
  llvm/test/CodeGen/MIR/AMDGPU/killed-flag-on-def-parse-error.mir


Index: llvm/test/CodeGen/MIR/AMDGPU/killed-flag-on-def-parse-error.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/MIR/AMDGPU/killed-flag-on-def-parse-error.mir
@@ -0,0 +1,12 @@
+# RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -run-pass=none %s -o /dev/null 2>&1 | FileCheck %s
+---
+name:            foo
+tracksRegLiveness: true
+body:             |
+  bb.0:
+
+    ; CHECK: [[@LINE+1]]:23: cannot have a killed def operand
+    killed %0:sgpr_32 = S_MOV_B32 0
+    S_ENDPGM 0
+
+...
Index: llvm/test/CodeGen/MIR/AMDGPU/dead-flag-on-use-operand-parse-error.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/MIR/AMDGPU/dead-flag-on-use-operand-parse-error.mir
@@ -0,0 +1,12 @@
+# RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -run-pass=none %s -o /dev/null 2>&1 | FileCheck %s
+---
+name:            foo
+tracksRegLiveness: true
+body:             |
+  bb.0:
+
+    %0:sgpr_32 = S_MOV_B32 0
+    ; CHECK: [[@LINE+1]]:24: cannot have a dead use operand
+    S_ENDPGM 0, dead %0
+
+...
Index: llvm/lib/CodeGen/MIRParser/MIParser.cpp
===================================================================
--- llvm/lib/CodeGen/MIRParser/MIParser.cpp
+++ llvm/lib/CodeGen/MIRParser/MIParser.cpp
@@ -1723,6 +1723,13 @@
         RegInfo->Kind == VRegInfo::REGBANK)
       return error("generic virtual registers must have a type");
   }
+
+  if ((Flags & RegState::Define) && (Flags & RegState::Kill))
+    return error("cannot have a killed def operand");
+
+  if (!(Flags & RegState::Define) && (Flags & RegState::Dead))
+    return error("cannot have a dead use operand");
+
   Dest = MachineOperand::CreateReg(
       Reg, Flags & RegState::Define, Flags & RegState::Implicit,
       Flags & RegState::Kill, Flags & RegState::Dead, Flags & RegState::Undef,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122583.418576.patch
Type: text/x-patch
Size: 1883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/863272eb/attachment.bin>