[PATCH] D122578: [cmake] fill `cmake_args` when crosscompiling external project with non-clang compiler

[Alexander Smarus via Phabricator via llvm-commits]

lxbndr created this revision.
lxbndr added a reviewer: compnerd.
lxbndr created this object with edit policy "Administrators".
lxbndr added a project: LLVM.
Herald added a subscriber: mgorny.
Herald added a project: All.
lxbndr requested review of this revision.
Herald added a subscriber: llvm-commits.

This makes it possible to crosscompile runtimes with cl.exe on Windows.

An external project is completely misconfigured otherwise because `cmake_args` is set only for native builds or builds crosscompiled with clang.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122578

Files:
  llvm/cmake/modules/LLVMExternalProjectUtils.cmake


Index: llvm/cmake/modules/LLVMExternalProjectUtils.cmake
===================================================================
--- llvm/cmake/modules/LLVMExternalProjectUtils.cmake
+++ llvm/cmake/modules/LLVMExternalProjectUtils.cmake
@@ -280,6 +280,8 @@
       foreach(type ${flag_types})
         list(APPEND cmake_args ${${type}_flag})
       endforeach()
+    else()
+      set(cmake_args ${ARG_CMAKE_ARGS})
     endif()
   else()
     set(llvm_config_path "$<TARGET_FILE:llvm-config>")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122578.418556.patch
Type: text/x-patch
Size: 489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220328/ec423f49/attachment.bin>