[PATCH] D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M

Mon Mar 28 05:30:33 PDT 2022

stuij added inline comments.
Herald added a project: All.

================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:4539
+          (Reg != ARM::RA_AUTH_CODE && !RC->contains(Reg)))
         return Error(AfterMinusLoc, "invalid register in register list");
       // Ranges must go from low to high.
----------------
RKSimon wrote:
> @stuij Static analysis is warning about dead code here - we've already handled the Reg == ARM::RA_AUTH_CODE case at line 4519, should this just be:
> ```
> if (!RC->contains(Reg))
>   return Error(AfterMinusLoc, "invalid register in register list");
> ```
Thanks! Made https://reviews.llvm.org/D122577 for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112429/new/

https://reviews.llvm.org/D112429