[PATCH] D122566: [AArch64] Set MaxBytesForLoopAlignment for more targets

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 02:42:39 PDT 2022


dmgreen added a comment.

Adding a MaxBytesForLoopAlignment without a PrefLoopLogAlignment doesn't seem to make a lot of sense. I don't think it would do much on its own. Can this add sensible values for PrefLoopLogAlignment at the same time?

It could then extend the test in D114879 <https://reviews.llvm.org/D114879> for all the CPUs added, to show it's tested.



================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:110-112
   case CortexA510:
   case CortexA710:
   case CortexX2:
----------------
These should be added too if they can be. They may need to be split into separate case blocks, if the A510 is different to the others now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122566/new/

https://reviews.llvm.org/D122566



More information about the llvm-commits mailing list