[PATCH] D122457: [LSR] Canonicalize formula before inserting it.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Yup, I agree with that. To me the initial formula

  reg((-1 * {0,+,8}<nuw><nsw><%bb2>)<nsw>) + 1*reg((8 * (%arg /u 8))<nuw>)

isn't canonical too, but because of wrong check (which simply checks that base reg isa SCEVAddRec) multiplication by one obfuscates this.

Let's see how deep this bug actually lies.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122457/new/

https://reviews.llvm.org/D122457