[PATCH] D122457: [LSR] Canonicalize formula before inserting it.

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 27 20:37:49 PDT 2022


skatkov added a comment.

In D122457#3410502 <https://reviews.llvm.org/D122457#3410502>, @mkazantsev wrote:

> Could you please elaborate what kind of crash do you see? Is it simply an assertion that something must be canonical and it's not, or something more sophisticated?

You'll get
bool LSRUse::InsertFormula(const Formula &F, const Loop &L) {

  assert(F.isCanonical(L) && "Invalid canonical representation");

on a attached test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122457/new/

https://reviews.llvm.org/D122457



More information about the llvm-commits mailing list