[PATCH] D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof.

[Zakk Chen via Phabricator via llvm-commits]

khchen added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:546
+    // tied def.
+    if (RISCVII::doesForceTailAgnostic(TSFlags))
+      TailAgnostic = true;
----------------
craig.topper wrote:
> arcbbb wrote:
> > This change implies that `ForceTailAgnostic` overrides all other rules.
> > Maybe we still want to keep the previous logic:
> > If there is a policy, we follow it.
> > Otherwise we look at the tied operand if ForceTailAgnostic is unset.
> ForceTailAgnostic is an instruction property. It shouldn't be set on any instructions that have a policy operand.
I think this change still keep the original logic because I force tail policy as agnostic if `ForceTailAgnostic` is true , but has more ability to decide the mask policy according to merge operand is undef or not.
You could see the `ForceTailAgnostic` is only used in this else if statement to keep the TailAgnostic would not be changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122456/new/

https://reviews.llvm.org/D122456