[PATCH] D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1111
       // Otherwise use
-      // vmslt{u}.vx vd, va, x, v0.t; vmxor.mm vd, vd, v0
+      // vmslt{u}.vx vd, va, x, v0.t; if mask policyt is agnostic.
       SDValue Cmp = SDValue(
----------------
policyt -> policy


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:546
+    // tied def.
+    if (RISCVII::doesForceTailAgnostic(TSFlags))
+      TailAgnostic = true;
----------------
arcbbb wrote:
> This change implies that `ForceTailAgnostic` overrides all other rules.
> Maybe we still want to keep the previous logic:
> If there is a policy, we follow it.
> Otherwise we look at the tied operand if ForceTailAgnostic is unset.
ForceTailAgnostic is an instruction property. It shouldn't be set on any instructions that have a policy operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122456/new/

https://reviews.llvm.org/D122456