[PATCH] D119973: RegAllocGreedy: Fix last chance recolor assert in impossible case
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 25 17:52:53 PDT 2022
qcolombet added a comment.
> Hmm, that's weird, if one register fails within the same level, we should roll back the whole level to its previous state.
Oh I think I see what you mean!
When we successfully recolor part of a level, the recoloring that happened below that level is not rolled back.
Yeah, I could totally see that problem now. I think we've been lucky so far because on failure most levels probably have only register to recolor.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119973/new/
https://reviews.llvm.org/D119973
More information about the llvm-commits
mailing list