[PATCH] D121737: [PseudoProbe] Do not emit pseudo probes when module is not probed.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 12:45:57 PDT 2022


hoy added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:1238-1242
+        emitWarning("Destination module missing pseudo-probe instrumentation: "
+                    "source moudle is '" +
+                    SrcM->getModuleIdentifier() +
+                    "' whereas destination module is '" +
+                    DstM.getModuleIdentifier() + "'\n");
----------------
wenlei wrote:
> Suggest rephrase the warning message with something like: `Pseudo-probe ignored: source module  (<module name>) is compiled with -fpseudo-probe-for-profiling while destination module  (<module name>) is not.`
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121737/new/

https://reviews.llvm.org/D121737



More information about the llvm-commits mailing list