[PATCH] D117426: [AVR] Only push and clear R1 in interrupts when necessary
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 25 09:01:08 PDT 2022
benshi001 accepted this revision.
benshi001 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/AVR/AVRISelDAGToDAG.cpp:460
+ // correctly zeroed in interrupts.
+ Ops.push_back(CurDAG->getRegister(AVR::R1, MVT::i8));
+
----------------
I am OK with current form. Just one more suggestion, you can add a new case of `icall`, current tests only contains a direct call but no indirect call. And you can add the `icall` test either in this patch or a new patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117426/new/
https://reviews.llvm.org/D117426
More information about the llvm-commits
mailing list