[PATCH] D122342: [lld][Mach-O][NFC] split parsing order file and processing its data.

Roger Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 08:10:31 PDT 2022


Roger created this revision.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
Roger updated this revision to Diff 417983.
Roger added a comment.
Roger updated this revision to Diff 417984.
Roger updated this revision to Diff 417991.
Roger updated this revision to Diff 417994.
Roger updated this revision to Diff 417995.
Roger edited the summary of this revision.
Roger updated this revision to Diff 418226.
Roger updated this revision to Diff 418229.
Roger published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Update


Roger added a comment.

Update


Roger added a comment.

Update


Roger added a comment.

Update


Roger added a comment.

Update


Roger added a comment.

Ready for review


Roger added a comment.

Add comment


Currently, the process of assigning priorities to sections for ordering is split across different points in the LLD pipeline. We can consolidate all the logic of assigning priorities under one function if we first split the code that gathers the data for assigning priorities (which needs to be done across different stages of the driver) from the code that actually assigns priorities (which can be done all at once when all the data has been collected). This diff prepares us for that change by splitting those two codes apart.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122342

Files:
  lld/MachO/Config.h
  lld/MachO/Driver.cpp
  lld/MachO/SectionPriorities.cpp
  lld/MachO/SectionPriorities.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122342.418229.patch
Type: text/x-patch
Size: 5720 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220325/296d8341/attachment.bin>


More information about the llvm-commits mailing list