[PATCH] D122071: [SDAG] enable binop identity constant folds for multiplies

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 04:32:53 PDT 2022


LuoYuanke added a comment.

In D122071#3407705 <https://reviews.llvm.org/D122071#3407705>, @RKSimon wrote:

> Thanks @LuoYuanke - can you think of any more nodes that we should add? There's plenty that can be added for completeness but I'm not sure which ones are causing actual perf issues - AND maybe? OR/XOR are less likely.

>From https://godbolt.org/z/8Mv6sj8hs, all the vector operation that getSelectFoldableOperands() covers can be compiled to optimal X86 instructions. The performance issue that is captured is about float operation (fsub, fadd) and they has been fixed. Thanks, Simon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122071/new/

https://reviews.llvm.org/D122071



More information about the llvm-commits mailing list