[PATCH] D122204: [RISCV][NFC] Remove redundant check and rename functions in some IR tests
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 25 03:57:30 PDT 2022
frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll:117
; CHECK-NEXT: ret
-i8>* %z2, <4 x i8>* %z3) {
store <4 x i8> <i8 0, i8 -1, i8 -2, i8 -3>, <4 x i8>* %z0
----------------
woah, how'd that happen, I wonder
================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vnsra-vnsrl.ll:2
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -mtriple=riscv32 -mattr=+v -riscv-v-vector-bits-min=128 -verify-machineinstrs < %s | FileCheck %s --check-prefixes=CHECK
; RUN: llc -mtriple=riscv64 -mattr=+v -riscv-v-vector-bits-min=128 -verify-machineinstrs < %s | FileCheck %s --check-prefixes=CHECK
----------------
We don't need `--check-prefixes=CHECK` here, since you're modifying the test anyway
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122204/new/
https://reviews.llvm.org/D122204
More information about the llvm-commits
mailing list