[PATCH] D122367: [AMDGPU] [NFC] Introduce subtargets check for MI hardware.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 03:23:20 PDT 2022


hsmhsm added a comment.

In D122367#3407538 <https://reviews.llvm.org/D122367#3407538>, @rampitec wrote:

> What's the reason behind this? You are not even using it.

I thought, it would be bit cleaner to use, for example ST.isGFX908Subtarget() compared to ST.hasMAIInsts() && !ST.hasGFX90AInsts().

So, if think, it does not make much sense, then I will ignore this patch, and abandon it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122367/new/

https://reviews.llvm.org/D122367



More information about the llvm-commits mailing list