[PATCH] D122259: [SelectOpti][2/5] Select-to-branch base transformation

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectOptimize.cpp:154
+    //       br label %select.end
+    //    select.end:
+    //       %sel = phi i32 [ %c, %start ], [ %d, %select.false ]
----------------
Can we have a test case to demonstrate that machine sinking is actually enabled with this transformation?


================
Comment at: llvm/lib/CodeGen/SelectOptimize.cpp:229
+        } else {
+          break;
+        }
----------------
should it skip debug stmts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122259/new/

https://reviews.llvm.org/D122259