[PATCH] D119880: [FuncSpec] Support function specialization across multiple arguments.

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 19:15:55 PDT 2022


ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM basically. Please wait for a few days in case there are other comments.



================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:542
 
-    if (OldArg == Arg.Formal) {
+    if (OldArg == (*Iter).Formal) {
       // Mark the argument constants in the new function.
----------------
Could we use `Iter->Formal`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119880/new/

https://reviews.llvm.org/D119880



More information about the llvm-commits mailing list