[PATCH] D122270: Support converting pointers from opaque to typed

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

In D122270#3406636 <https://reviews.llvm.org/D122270#3406636>, @aeubanks wrote:

> I would consider forking the bitcode writer and its dependencies like ValueEnumerator rather than trying to share code. Having to support 3.7 bitcode features in the "official" bitcode writer doesn't seem appealing, however small the features may be. I see 3.7 bitcode as a completely new backend rather than a slight variation on LLVM head IR. The bitcode reader is already quite complicated due to maintaining backward compatibility, I would prefer if that didn't happen with the bitcode writer.

That is a reasonable approach. Worth noting, the ValueEnumerator really just maps IR constructs to stable IDs, it is used by the bitcode writer, but other than a few cases of unclean abstractions, has no real binding to the bitcode format.

My patch does completely fork the bitcode writer, I'm just trying to share the ValueEnumerator and bitcode writer pass at the moment. I can also fork both of those too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122270/new/

https://reviews.llvm.org/D122270