[PATCH] D121848: [scudo] Remove unused header includes and fix declarations

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/wrappers_c.h:22
 
+extern "C" void malloc_postinit();
+extern scudo::Allocator<scudo::Config, malloc_postinit> Allocator;
----------------
ddcc wrote:
> vitalybuka wrote:
> > Why do we need this?
> `-Wmissing-variable-declarations` complains about no previous extern declaration for `Allocator` in `wrappers_c.cpp`, so the intention was to centralize the duplicate extern declarations between `wrappers_c.cpp` and `wrapper_cpp.cpp`, but I think that got lost while splitting the commits, and I missed that there's a `SCUDO_PREFIX` macro here, so I'll just add a declaration to `wrappers_c.cpp` instead.
Cab we move extern to the patch where actually it's necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121848/new/

https://reviews.llvm.org/D121848